Skip to content

fix: clear readiness hooks flag after ModuleDelete#651

Merged
ldmonster merged 3 commits intomainfrom
fix/multiple-readines-hooks-false-positive-after-moduledelete
Aug 21, 2025
Merged

fix: clear readiness hooks flag after ModuleDelete#651
ldmonster merged 3 commits intomainfrom
fix/multiple-readines-hooks-false-positive-after-moduledelete

Conversation

@diafour
Copy link
Contributor

@diafour diafour commented Aug 14, 2025

Overview

Clear readiness hooks flag after ModuleDelete

What this PR does / why we need it

ModuleDelete and ModuleRun during lifecycle leads to an error:

 1. ModuleRun:parallel_queue_8:<MODULE_NAME>:doStartup:ReloadAllModules:failures 121:
register hooks search module hooks failed: search module batch hooks:
multiple readiness hooks found in <HOOK_FILE_PATH>

Special notes for your reviewer

ModuleDelete and ModuleRun during lifecycle leads to an error:

 1. ModuleRun:parallel_queue_8:<MODULE_NAME>:doStartup:ReloadAllModules:failures 121:register hooks search module hooks failed: search module batch hooks: multiple readiness hooks found in <HOOK_FILE_PATH>

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour requested review from ldmonster and yalosev August 14, 2025 19:04
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@ldmonster ldmonster added the enhancement New feature or request label Aug 21, 2025
@ldmonster ldmonster merged commit 8f367df into main Aug 21, 2025
8 of 9 checks passed
@ldmonster ldmonster deleted the fix/multiple-readines-hooks-false-positive-after-moduledelete branch August 21, 2025 14:47
@ldmonster ldmonster restored the fix/multiple-readines-hooks-false-positive-after-moduledelete branch September 18, 2025 12:17
@ldmonster ldmonster deleted the fix/multiple-readines-hooks-false-positive-after-moduledelete branch September 18, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants