Skip to content

Comments

[fix] inject module registry to values#667

Merged
ldmonster merged 5 commits intomainfrom
fix/inject-module-registry
Sep 15, 2025
Merged

[fix] inject module registry to values#667
ldmonster merged 5 commits intomainfrom
fix/inject-module-registry

Conversation

@ipaqsa
Copy link
Contributor

@ipaqsa ipaqsa commented Sep 11, 2025

Overview

Modules(like pod-reloader) may have no properties in values.yaml, we skipped such modules and it causes validation problem.

The problem was not revealed before because it happens only if you delete a module(remove old injection on fs)

 1. ModuleRun:parallel_queue_1:pod-reloader:doStartup:OperatorStartup:failures 19:run helm install: check helm values: 1 error occurred:
	* podReloader.registry is a forbidden property

And result values are override after recalculation, so use static values

What this PR does / why we need it

Fixes the registry injection

Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
@ipaqsa ipaqsa requested a review from ldmonster September 11, 2025 23:04
@ipaqsa ipaqsa self-assigned this Sep 11, 2025
@ipaqsa ipaqsa added go Pull requests that update Go code release-note/enhancement New feature or request labels Sep 11, 2025
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
@ipaqsa ipaqsa marked this pull request as draft September 12, 2025 08:42
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
@ipaqsa ipaqsa marked this pull request as ready for review September 12, 2025 09:17
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
@ipaqsa ipaqsa marked this pull request as draft September 12, 2025 10:05
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
@ipaqsa ipaqsa marked this pull request as ready for review September 12, 2025 12:16
@ipaqsa ipaqsa requested a review from yalosev September 15, 2025 07:51
@ldmonster ldmonster merged commit 635642c into main Sep 15, 2025
8 of 9 checks passed
@ldmonster ldmonster deleted the fix/inject-module-registry branch September 15, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code release-note/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants