Skip to content

Comments

[chore][helm] dont create chart file for helm module#674

Closed
brileyyyy wants to merge 1 commit intomainfrom
feat/handle-virtual-chart
Closed

[chore][helm] dont create chart file for helm module#674
brileyyyy wants to merge 1 commit intomainfrom
feat/handle-virtual-chart

Conversation

@brileyyyy
Copy link
Contributor

@brileyyyy brileyyyy commented Sep 23, 2025

Overview

Addon tries to create a Chart.yaml for a helm module, but it will fail on read only fs.
This PR fixes it for helm client.

What this PR does / why we need it

If a module does not have Chart.yaml, we make it 'virtual' and call helm loading again.

WARNING:
IT IS NOT THE BEST SOLUTION, BUT IT SEEMS ENOUGH FOR NOW

WARNING:
NELM DOES NOT SUPPORT IT

@brileyyyy brileyyyy self-assigned this Sep 23, 2025
@brileyyyy brileyyyy added the enhancement New feature or request label Sep 23, 2025
@ipaqsa ipaqsa requested review from ipaqsa and ldmonster September 24, 2025 13:46
@ipaqsa ipaqsa changed the title [addon-operator] Manage chart creation for a read-only filesystem [chore] dont create chart file for module Sep 24, 2025
@ipaqsa ipaqsa requested a review from yalosev September 24, 2025 15:25
@ipaqsa ipaqsa changed the title [chore] dont create chart file for module [chore][helm] dont create chart file for helm module Oct 7, 2025
@ipaqsa ipaqsa force-pushed the feat/handle-virtual-chart branch 2 times, most recently from d213dbd to 7638b53 Compare October 7, 2025 21:23
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
@ipaqsa ipaqsa force-pushed the feat/handle-virtual-chart branch from 7638b53 to aa9b8f3 Compare October 8, 2025 18:53
@ipaqsa ipaqsa closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants