Don't disable monitors before after delete hook run#675
Merged
Conversation
Signed-off-by: Timur Tuktamyshev <timur.tuktamyshev@flant.com>
ipaqsa
approved these changes
Sep 25, 2025
ldmonster
approved these changes
Sep 30, 2025
ldmonster
pushed a commit
that referenced
this pull request
Sep 30, 2025
Signed-off-by: Timur Tuktamyshev <timur.tuktamyshev@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Defer stopping Kubernetes monitors for modules scheduled to be disabled. In converge phase, only disable schedule bindings; keep Kubernetes watchers alive until
afterDeleteHelmruns duringDeleteModule. Full hook disabling still happens right afterafterDeleteHelm.What this PR does / why we need it
ModulesToDisable. As a side effect,afterDeleteHelmhooks received empty snapshots because monitors were already stopped.DeleteModulecan executeafterDeleteHelmwith populated snapshots.DisableModuleHooksis still invoked inDeleteModuleright afterafterDeleteHelm, stopping both schedules and monitors.Why needed:
afterDeleteHelmhooks receive snapshots of their Kubernetes bindings.