[chore][nelm] dont create chart file for helm module #679
Closed
[chore][nelm] dont create chart file for helm module #679
Conversation
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
ipaqsa
changed the title
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
ipaqsa
force-pushed
the
feat/handle-virtual-chart-nelm
branch
from
e83411f to
8c76e99
Compare
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: kerimov <brileyforbusiness@gmail.com>
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the existing virtual Chart.yaml functionality to support nelm, completing the readonly filesystem compatibility that was previously implemented only for Helm.
What this PR does / why we need it
This PR implements virtual chart support for nelm. If a module does not have Chart.yaml, we make it 'virtual' and call nelm loading again.