[addon-operator] Fix/readiness bug #704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix "multiple readiness hooks found" false positive error during module hook registration retry.
What this PR does / why we need it
When
RegisterHooks()fails aftersearchModuleBatchHooks()has already found a readiness hook (e.g., error inAssembleEnvironmentForModule()), thehasReadinessflag remainstruewhilehooks.registeredstaysfalse. On retry,searchModuleBatchHooks()finds the same readiness hook again but seeshasReadinessalready set totrue, incorrectly reporting "multiple readiness hooks found".Root cause:
searchModuleBatchHooks()was modifyingbm.hasReadinessas a side effect during the search, before registration was complete.Fix: Refactored
searchModuleBatchHooks()to be a pure function that returnshasReadinessas a separate value instead of modifying the struct field directly. Thebm.hasReadinessfield is now set only inRegisterHooks()after successful registration.