Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
There seems to be internal confusion as to whether
retry_countreally means "tries", where 0--which is a legal value--means never try at all or "retries", where 0 means try once (but never "retry"). My assumption is that no one really intends to disable the action by settingretry_count=0.This tries to clear that up by updating
safe_to_snap()soretry_count=1results in exactly 1 try and by modifying the default to be 2 so as to preserve the current default behavior. If preserving the number of retries that happen based on a particular input is more important, perhaps it would be best to just makeretry_count=0an illegal value.I've also updated the help text for the
--retry_countoption for the singleton CLI tool to reflect that the max is 100 (not 3--I'm guessing this was a mixup between "max" and "default")