refactor(core): make search debounce time extensible#4172
Merged
SychO9 merged 1 commit intoflarum:2.xfrom Jan 31, 2025
Merged
Conversation
9 tasks
SychO9
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.xequivalent to #4171Fixes #0000
Third-party extensions might want to adjust the search debounce time. Currently, it's very hard to customize this value.
Changes proposed in this pull request:
Create a new constant
SEARCH_DEBOUNCE_TIME_MSfor the search debounce timeout. Allows to third-party extensions to easily customize this value.Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test).Required changes: