Skip to content

[1.x] fix(core): change starting position of aria-posinset#4192

Merged
imorland merged 1 commit intoflarum:1.xfrom
glowingblue:di/aria-posinset-index
Feb 15, 2025
Merged

[1.x] fix(core): change starting position of aria-posinset#4192
imorland merged 1 commit intoflarum:1.xfrom
glowingblue:di/aria-posinset-index

Conversation

@DavideIadeluca
Copy link
Copy Markdown
Contributor

Fixes #4143

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 11, 2025 08:17
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner February 11, 2025 08:17
@imorland imorland added this to the 1.8.10 milestone Feb 15, 2025
@imorland imorland merged commit 3d60841 into flarum:1.x Feb 15, 2025
321 checks passed
@imorland imorland deleted the di/aria-posinset-index branch February 15, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants