[2.x] feat(subscriptions): add support for auto follow discussions on create#4464
Open
huoxin233 wants to merge 1 commit intoflarum:2.xfrom
Open
[2.x] feat(subscriptions): add support for auto follow discussions on create#4464huoxin233 wants to merge 1 commit intoflarum:2.xfrom
huoxin233 wants to merge 1 commit intoflarum:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR introduces a new setting in the
flarum/subscriptionsextension that automatically subscribes users to discussions they created.The original
followAfterReplydoes cover discussion creation also, but not all users will want to follow every discussion they reply to, thats why afollowAfterCreateis needed.The default preference for
followAfterCreateis set to true as discussion creators usually want to know when someone replied to their discussion.Reviewers should focus on:
Would you consider including this in the core extension? Or should it be extended using another extension, as shown in my extension: https://discuss.flarum.org/d/34680-auto-follow-discussion
There have also been quite a few discussions on this behavior over the years:
Personally, I would definitely like to see this in core as this is something that should come out of the box.
Screenshot
Necessity
Confirmed
composer test).Required changes: