[2.x] fix: make user search case-insensitive across all supported databases#4467
Merged
[2.x] fix: make user search case-insensitive across all supported databases#4467
Conversation
MySQL/MariaDB already handles this via collation (LIKE), PostgreSQL now uses ILIKE, and SQLite uses LOWER(username) LIKE since its LIKE is only ASCII case-insensitive. Applies to both FulltextFilter (API/user directory search) and UserRepository::getIdsForUsername (mention autocomplete etc).
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIKEoperator is case-sensitive, causing user search on the/userspage (and mention autocomplete) to miss results that differ only in caseFulltextFilternow usesILIKEon PostgreSQL,LOWER(username) LIKEon SQLite, and unchangedLIKEon MySQL/MariaDB (already case-insensitive via collation)UserRepository::getIdsForUsernamereceives the same treatment, including its prefix-matchORDER BYclausesmatch()pattern already used inDiscussion\Search\FulltextFilterTest plan
@Usernamewith wrong case) works on PostgreSQL