Optimize sparse logic with block-level Tensor Core utilization#110
Draft
Optimize sparse logic with block-level Tensor Core utilization#110
Conversation
Contributor
Author
|
@LoserCheems 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: LoserCheems <124847097+LoserCheems@users.noreply.github.com>
Co-authored-by: LoserCheems <124847097+LoserCheems@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Optimize sparse logic
Optimize sparse logic with block-level Tensor Core utilization
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current sparse logic implementation uses an all-or-nothing approach that doesn't effectively utilize Tensor Cores. When any element in the active mask is non-zero, it performs full dense computation, which leads to suboptimal performance for block-sparse patterns.
Problem
The existing
sparse_gemmfunctions check sparsity at the entire tensor level:This approach doesn't leverage structured sparsity patterns and underutilizes Tensor Core capabilities when dealing with partially sparse blocks.
Solution
Implemented two optimization strategies as suggested in the issue:
1. Early Branching with Block-Level Analysis
The optimization now analyzes sparsity at MMA block granularity and provides three computation paths:
2. Active Block Batching
The implementation counts active blocks and optimizes memory loading accordingly:
Benefits
Performance Impact
Expected performance improvements based on sparsity patterns:
The optimization maintains full compatibility with the existing codebase while providing significant performance benefits for sparse attention patterns commonly found in long-sequence transformers.
Fixes #88.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.