Add optional mask & bias inputs with adaptive computation skipping#162
Draft
Add optional mask & bias inputs with adaptive computation skipping#162
Conversation
…al mask/bias Co-authored-by: LoserCheems <124847097+LoserCheems@users.noreply.github.com>
…essing Co-authored-by: LoserCheems <124847097+LoserCheems@users.noreply.github.com>
…on skipping Co-authored-by: LoserCheems <124847097+LoserCheems@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [FEATURE REQUEST] Optional mask & bias inputs with adaptive computation skipping
Add optional mask & bias inputs with adaptive computation skipping
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements optional
attn_maskandattn_biasinputs with adaptive computation skipping to improve performance and reduce unnecessary memory operations in Flash Dynamic Mask Attention.Problem
The current implementation always assumes both
attn_maskandattn_biasare active, causing:Solution
Added support for 4 explicit modes with conditional processing:
NoneNoneTensorNoneNoneTensorTensorTensorKey Changes
Python Interface
attn_maskandattn_biasparameters now acceptOptional[Tensor] = Noneuse_maskanduse_biasflags passed to CUDA kernelsdbiasreturned only when bias providedCUDA Kernels
use_bias=FalseUsage Example
Performance Benefits
Backward Compatibility
The implementation is fully backward compatible - existing code continues to work unchanged. Default parameter values maintain current behavior when not specified.
Fixes #161.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.