Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ jobs:
export FLASH_DMATTN_CUDA_ARCHS="${MATRIX_ARCH}"
fi

# 5h timeout since GH allows max 6h and we want some buffer
# GH allows max 6h
EXIT_CODE=0
timeout 5h python setup.py bdist_wheel --dist-dir=dist || EXIT_CODE=$?
timeout 6h python setup.py bdist_wheel --dist-dir=dist || EXIT_CODE=$?
Comment on lines +183 to +185
Copy link

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the timeout to exactly 6h (GitHub's maximum) removes any buffer time for cleanup operations or error handling. Consider using 5h45m to maintain a small buffer for graceful termination and cleanup processes.

Copilot uses AI. Check for mistakes.

if [ $EXIT_CODE -eq 0 ]; then
if [ -n "${MATRIX_ARCH}" ]; then
Expand Down