Use SCALE rather than JSON for encoding attestation payloads #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON is not good for encoding binary - so use SCALE for encoding
AttestationPayload.I chose this because it is very simple and actually matches how TDX quotes are encoded, meaning we already had it as a dependency - as
dcap-qvluses it: https://github.com/Phala-Network/dcap-qvl/blob/9cf169c3c4985c747dab116f6ff953c1c16cb8c3/src/quote.rs#L5The attestation type enum is first encoded as a string, not a variant number - which i thought might be better for interoperability or backwards compatibility.