Skip to content

Use always absolute output path #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canercidam merged 3 commits into from
Feb 16, 2026
Merged

Use always absolute output path #344

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aa80ed
Use always absolute output path
ferranbt Jan 28, 2026
f43ab0b
Remove use of absolute path in runtime
ferranbt Jan 28, 2026
5800a40
Merge branch 'main' into ferranbt-fix-relative-output-host-path
canercidam Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions playground/artifacts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,14 @@ func NewOutput(dst string) (*output, error) {
if dst == "" {
// Use the $HOMEDIR/devnet as the default output
dst = filepath.Join(homeDir, "devnet")
} else {
// Convert relative paths to absolute paths
if !filepath.IsAbs(dst) {
dst, err = filepath.Abs(dst)
if err != nil {
return nil, fmt.Errorf("failed to convert relative path to absolute: %w", err)
}
}
}

out := &output{dst: dst, homeDir: homeDir}
Expand All @@ -548,10 +556,6 @@ func (o *output) Read(path string) (string, error) {
return string(data), nil
}

func (o *output) AbsoluteDstPath() (string, error) {
return filepath.Abs(o.dst)
}

func (o *output) Exists(path string) bool {
_, err := os.Stat(filepath.Join(o.dst))
return err == nil
Expand Down
6 changes: 2 additions & 4 deletions playground/components_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,8 @@ func (tt *testFramework) test(component ComponentGen, args []string) *Manifest {
t.Fatal(err)
}

o := &output{
dst: e2eTestDir,
homeDir: filepath.Join(e2eTestDir, "artifacts"),
}
o, err := NewOutput(e2eTestDir)
require.NoError(t, err)

exCtx := &ExContext{
Output: o,
Expand Down
5 changes: 1 addition & 4 deletions playground/local_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,10 +497,7 @@ func (d *LocalRunner) toDockerComposeService(s *Service) (map[string]interface{}

// The containers have access to the full set of artifacts on the /artifacts folder
// so, we have to bind it as a volume on the container.
outputFolder, err := d.out.AbsoluteDstPath()
if err != nil {
return nil, nil, fmt.Errorf("failed to get absolute path for output folder: %w", err)
}
outputFolder := d.out.Dst()

// Validate that the image exists
imageName := fmt.Sprintf("%s:%s", s.Image, s.Tag)
Expand Down