Conversation
|
Claude finished @dvush's task in 53s —— View job PR Review
SummaryThe PR adds the Safe Singleton Factory (a deterministic CREATE2 deployer) to both L1 and L2 genesis allocations. The implementation is clean and straightforward — defines the canonical address and runtime bytecode as package-level vars and injects them in both genesis paths. Issues
|
| } | ||
|
|
||
| // add Safe Singleton Factory (deterministic CREATE2 deployer) | ||
| appendSafeSingletonFactoryToAlloc(&gen.Alloc) |
There was a problem hiding this comment.
The Safe Singleton Factory is added before Optimism L1 allocs are applied via maps.Copy (line 277). If the Optimism allocs ever include the same address (0x914d7Fec6aaC8cd542e72Bca78B30650d45643d7), maps.Copy will silently overwrite it. Consider moving this call after the Optimism allocs are applied, or at least after line 277, to ensure the factory is always present.
|
Its better for users to add is via predeploy feature of the playground |
This is very useful because you can deploy all contact on the same address on all chains with this https://github.com/safe-fndn/safe-singleton-factory