Skip to content

Conversation

@scharissis
Copy link
Contributor

Fixes silent error swallowing in campaign execution.

The tokio::select! block was discarding errors by binding the result to _. When execute_stage returned an error (e.g., MinBalanceInsufficient when default min-balance is too low), the campaign would silently exit with "Campaign completed" instead of showing the error.

@zeroXbrock
Copy link
Member

absorbing #419 with this

@zeroXbrock zeroXbrock changed the title fix: propagate campaign execution errors fix: propagate campaign execution errors + fix-campaign-seeds Jan 20, 2026
Copy link
Member

@zeroXbrock zeroXbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thank you @bitwiseguy @scharissis!

@zeroXbrock zeroXbrock merged commit 3e8d63a into flashbots:main Jan 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants