config: derive version from Go module build info#891
Open
mark-liu wants to merge 2 commits intoflashbots:developfrom
Open
config: derive version from Go module build info#891mark-liu wants to merge 2 commits intoflashbots:developfrom
mark-liu wants to merge 2 commits intoflashbots:developfrom
Conversation
|
Thank you for fixing this |
Author
|
Friendly ping — any chance this could get a review? Happy to address feedback. |
Author
|
Friendly ping — this derives the version from Go module build info so it stays accurate without manual updates. Happy to address feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889.
When mev-boost is installed via
go install ...@latest, the version string can be empty/unknown unless ldflags are provided. This change derives Version from Go build info / module metadata as a fallback.Tests:
go test ./...