fix JSON log marshaling error in registerValidator#895
Open
dom-nie wants to merge 1 commit intoflashbots:developfrom
Open
fix JSON log marshaling error in registerValidator#895dom-nie wants to merge 1 commit intoflashbots:developfrom
dom-nie wants to merge 1 commit intoflashbots:developfrom
Conversation
Remove *http.Request from logrus fields in registerValidator debug log. The http.Request.GetBody field (func type) causes json.Marshal to fail when running with -json log formatting, silently dropping the log entry. Closes flashbots#894
There was a problem hiding this comment.
Pull request overview
Fixes JSON-formatted logging in registerValidator by removing an unmarshalable *http.Request from logrus fields, preventing json.Marshal failures and dropped log entries when -json is enabled.
Changes:
- Remove
*http.Requestfrom the debug log fields inregisterValidator. - Keep the debug log message while relying on the existing per-relay
urlfield for context.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*http.Requestfrom logrus fields inregisterValidatordebug loghttp.Request.GetBodyfield (func() (io.ReadCloser, error)) causesjson.Marshalto fail when running with-jsonlog formatting, printingFailed to obtain readerto stderr and silently dropping the log entryurlis already present on the logger context (set at line 35), so no useful information is lostCloses #894