Skip to content

Conversation

@metachris
Copy link
Contributor

Add ARM64 as target platform for Docker builds.

Copilot AI review requested due to automatic review settings January 26, 2026 09:24
@metachris metachris requested a review from sukoneck as a code owner January 26, 2026 09:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds ARM64 architecture support to the Docker build pipeline, enabling multi-platform image builds for both AMD64 and ARM64 architectures.

Changes:

  • Updated Docker build platform configuration to include linux/arm64 alongside existing linux/amd64

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link
Contributor

claude bot commented Jan 26, 2026

Claude finished @metachris's task in 56s —— View job


Review Summary

LGTM

This is a well-structured, minimal change that adds ARM64 as a target platform for Docker builds.

Analysis

What changed:

  • Line 317: platforms: linux/amd64platforms: linux/amd64,linux/arm64

Verification:

  1. Dockerfile is already ARM64-ready: The docker/Dockerfile.rbuilder already handles multi-platform builds correctly:

    • Uses TARGETPLATFORM build argument (line 13)
    • Has platform-specific logic for sccache binary downloads (lines 22-30) supporting both linux/amd64 and linux/arm64
    • Uses platform-agnostic base images (rust:1.89-bookworm, gcr.io/distroless/cc-debian12)
  2. Workflow has proper prerequisites: The workflow already includes:

    • QEMU setup (docker/setup-qemu-action@v3 at line 282) for cross-platform emulation
    • Buildx setup (docker/setup-buildx-action@v3 at line 285) for multi-platform builds

Considerations

Build time impact: ARM64 builds via QEMU emulation on x64 runners can be significantly slower than native builds. This is expected behavior but worth noting for CI timing expectations.

No issues found - the change is correct and all prerequisites for multi-platform builds are already in place.


@ZanCorDX
Copy link
Collaborator

Took more than 2hs to build.

@ZanCorDX ZanCorDX closed this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants