Skip to content

Conversation

yongwww
Copy link
Collaborator

@yongwww yongwww commented Aug 11, 2025

πŸ“Œ Description

πŸ” Related Issues

πŸš€ Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

βœ… Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

πŸ§ͺ Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

cc: @yzh119 @paul841029

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @yongwww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues with cuda-python version 13.0 by updating import paths within the codebase and relaxing the version constraint in the project's dependencies. This ensures the project can correctly utilize newer cuda-python versions, preventing import errors and allowing for broader compatibility with recent CUDA environments.

Highlights

  • CUDA Import Path Update: Modified flashinfer/comm/mnnvl.py to use the new cuda.bindings.runtime import path for cudart, resolving compatibility with cuda-python v13.0.
  • CUDA Utility Import Refactoring: In flashinfer/cuda_utils.py, I refactored multiple cuda.bindings imports into a single from cuda.bindings import driver, nvrtc, runtime statement and updated the cudaGetErrorName call to use the runtime module.
  • Dependency Version Relaxation: The setup.py file was updated to remove the upper version constraint (<=12.9) for cuda-python, allowing installations with cuda-python v13.0 and newer.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add compatibility for cuda-python v13.0 by updating import paths and removing the version constraint in setup.py. The changes are mostly correct, but there is a critical import error in flashinfer/cuda_utils.py that will prevent the code from running. I've provided a suggestion to correct the import statement.

@yongwww yongwww marked this pull request as draft August 11, 2025 18:26
@yongwww yongwww marked this pull request as ready for review August 11, 2025 18:33
@yzh119 yzh119 merged commit b741065 into flashinfer-ai:main Aug 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants