Skip to content

Add CUDA arch 12.0 to installation guide #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CUDA arch 12.0 to installation guide #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/installation.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ You can follow the steps below to install FlashInfer from source code:
.. code-block:: bash

cd flashinfer
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a"
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a 12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other architectures in this list like 9.0a and 10.0a, 12.0 should likely be 12.0a. The a suffix is often important for enabling specific hardware features (like Tensor Cores) during compilation. Using an incorrect identifier could lead to build failures or suboptimal performance.

Suggested change
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a 12.0"
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a 12.0a"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

python -m flashinfer.aot # Produces AOT kernels in aot-ops/
python -m pip install --no-build-isolation --verbose .

Expand Down Expand Up @@ -109,7 +109,7 @@ You can follow the steps below to install FlashInfer from source code:
.. code-block:: bash

cd flashinfer
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a"
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a 12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other architectures in this list like 9.0a and 10.0a, 12.0 should likely be 12.0a. The a suffix is often important for enabling specific hardware features (like Tensor Cores) during compilation. Using an incorrect identifier could lead to build failures or suboptimal performance.

Suggested change
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a 12.0"
export FLASHINFER_CUDA_ARCH_LIST="7.5 8.0 8.9 9.0a 10.0a 12.0a"

python -m flashinfer.aot # Produces AOT kernels in aot-ops/
python -m build --no-isolation --wheel
ls -la dist/
Expand Down