Skip to content

Conversation

sricketts
Copy link
Member

@sricketts sricketts commented Oct 2, 2025

📌 Description

For #1833 - adds coverage for all CLI commands in flashinfer/__main__.py.

🔍 Related Issues

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

Do we want all tests in a single file or split by command?

@sricketts
Copy link
Member Author

Main remaining items:

  • Fix module-status test (currently hitting error during module registration)
  • Maybe: add additional module tests as listed by TODO items in the code (or we can leave these for follow up PRs)
  • Get these tests added to internal and public CI

@sricketts sricketts self-assigned this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant