-
Notifications
You must be signed in to change notification settings - Fork 820
fix api breaking changes #2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix api breaking changes #2832
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,8 +155,6 @@ def xqa( | |
| q: torch.Tensor, | ||
| k_cache: torch.Tensor, | ||
| v_cache: torch.Tensor, | ||
| k_sf_cache: Optional[torch.Tensor], | ||
| v_sf_cache: Optional[torch.Tensor], | ||
| page_table: torch.Tensor, | ||
| seq_lens: torch.Tensor, | ||
| output: torch.Tensor, | ||
|
|
@@ -174,6 +172,9 @@ def xqa( | |
| rcp_out_scale: float = 1.0, | ||
| q_seq_len: int = 1, | ||
| mask: Optional[torch.Tensor] = None, | ||
| *, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why does these parameters need to be keyword only?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think it's optional feature (guessing) to that end the rationale is documented (end of this page) https://github.com/flashinfer-ai/flashinfer/blob/main/CONTRIBUTING.md
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'd like to put a * as soon as basic feature are done in the api. the extra things that pile on later passed positionally just gets worse and worse for api stability imo positional args shouldn't exceed 10, or it becomes harder to maintain
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. great questions! keep them coming |
||
| k_sf_cache: Optional[torch.Tensor] = None, | ||
| v_sf_cache: Optional[torch.Tensor] = None, | ||
| ) -> None: | ||
| r"""Apply attention with paged KV cache using XQA kernel. | ||
| Parameters | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.