This repository was archived by the owner on May 30, 2023. It is now read-only.
bump etcd and flannel to the latest versions to get multiarch images for arm64 support#1179
Merged
bump etcd and flannel to the latest versions to get multiarch images for arm64 support#1179
Conversation
c9767b6 to
3e0b128
Compare
3e0b128 to
24b59fa
Compare
tormath1
reviewed
Aug 11, 2021
14 tasks
Contributor
|
@pothos for the failing tests Once merged, we can open an issue to track everything related to
|
24b59fa to
3f558ee
Compare
jepio
approved these changes
Aug 26, 2021
Contributor
Author
|
@tormath1 Should I squash and merge or do you want to do it? |
Contributor
|
@pothos feel free to do it :) |
f77e5a6 to
00c2264
Compare
Contributor
Author
|
Thanks for taking over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of kola tests fail because on
arm64we don't haveetcdandflannelworking due to using an image tag by default that isn't a multiarch image.things to keep in mind:
etcdnow defaults tov3- I guess this is something we'd like to communicate for people usingetcdshipped by Flatcar (we can also update theetcd-member.serviceto keep V2 support and let users doing the upgrade)flannelandlocksmithdoes not supportetcd/v3: we need to startetcdwith--enable-v2+ useETCDCTL_API=2(there is an on-going effort to portlocksmithtov3: upgrade to etcd/client/v3 flatcar/locksmith#12)How to use
The new image tags used here are multiarch images and it should work to pass the kola tests on arm64 with them.
Testing done
CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3368/cldsv/
amd64: 🔵arm64: 🔴 it only remains thekubeadm.*test to pass; which should be quite trivial to fix I hope (see: flatcar/Flatcar#474)