sys-boot/grub: sync with gentoo upstream; updates to 2.06#2098
sys-boot/grub: sync with gentoo upstream; updates to 2.06#2098sayanchowdhury wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
krnowak
left a comment
krnowak
left a comment
There was a problem hiding this comment.
Looked at some things, but haven't gone through the GPT code in patches yet.
| data directly instead of the generic grub_partition structure. It will | ||
| be the basis for modules that need to read/write/update GPT data. | ||
|
|
||
| Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com> |
There was a problem hiding this comment.
Maybe use your work email for signoffs?
| Read the verity hash from the kernel binary and pass it to the running | ||
| system via the kernel command line | ||
|
|
||
| Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com> |
| # Flatcar: Add arm64 to the list of platforms | ||
| GRUB_ALL_PLATFORMS+=( arm64 ) |
There was a problem hiding this comment.
Do we still need this modification? My guess would be that it comes from times when grub in gentoo was not supported on arm64. I also don't understand why this was used for pulling in a cross-compiler…
| sys-devel/bison | ||
| sys-apps/help2man | ||
| sys-apps/texinfo | ||
| grub_platforms_arm64? ( cross-aarch64-cros-linux-gnu/gcc ) |
There was a problem hiding this comment.
Here you dropped the fonts ( freetype, pkgconfig }. I think it's unnecessary difference between our ebuild and Gentoo - we don't enable fonts USE flag anyway, so it could stay as is.
| From 026cab86883e256607f6df30375bfda4468ae71e Mon Sep 17 00:00:00 2001 | ||
| From: Michael Marineau <michael.marineau@coreos.com> | ||
| Date: Sun, 28 Sep 2014 21:26:21 -0700 | ||
| Subject: [PATCH] gpt: start new GPT module |
There was a problem hiding this comment.
There is also
commit e49d5b587e46cd4611be2a5a18d2c2f8c9a40281
Author: Michael Marineau <michael.marineau@coreos.com>
Date: Mon Nov 3 17:14:37 2014 -0800
gpt: new gptprio.next command for selecting priority based partitions
and I don't see it as separate patch, yet it seems the contents of it are here - did you merge both patches or is this a newer patch from a different repo or branch and not found as is on the flatcar-master branch?
There was a problem hiding this comment.
In any case it would be good to add all the details in the commit message of your "sys-boot/grub: Apply Flatcar patches" commit.
|
For testing we have the kola qemu update test but it doesn't cover the downgrade case. This has to be done manually with |
3 participants
sys-boot/grub: sync with gentoo upstream; updates to 2.06
Testing done
Jenkins CI http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/6311/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)