backend: update echo prom to new library#1152
Open
tylerauerbeck wants to merge 1 commit intoflatcar:mainfrom
Open
backend: update echo prom to new library#1152tylerauerbeck wants to merge 1 commit intoflatcar:mainfrom
tylerauerbeck wants to merge 1 commit intoflatcar:mainfrom
Conversation
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
ervcz
approved these changes
Jul 28, 2025
Collaborator
ervcz
left a comment
There was a problem hiding this comment.
Thank you @tylerauerbeck for this contribution!
Double checked myself as well, the metrics endpoint seems to be functioning the same way as before :)
tormath1
reviewed
Jul 28, 2025
Contributor
tormath1
left a comment
There was a problem hiding this comment.
CI is failling:
panic: duplicate metrics collector registration attempted [recovered]
panic: duplicate metrics collector registration attempted
Quickly checking the diff between the two libs, the "old" one is using defaultSubsystem = "echo" to register the Prometheus middleware while the "new one" uses the serviceName.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend: use updated echo prometheus library
echohas an updatedprometheuslibrary that they recommend moving toward. While the existing library isn't outright labeled as outdated, most documentation points at migrating to the new library.How to use
Startup Nebraska/backend as expected. Hit the
/metricsendpoint and verify that the expected metrics are in place.Testing done
make cito ensure no existing code is impacted. A quick glance at metrics appears to show the samemetricsoutputchangelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.