Fix GHA CI for PRs from external contributors #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls in a commit in emerge-gitclone, that adapts emerge-gitclone to work for commits for PRs from external contributors. Signed-off-by: Jeremi Piotrowski <[email protected]>
This gives emerge-gitclone the full sha so that it can fetch by hash from the remote repository, which lets it succeed for PRs from external contributors. Signed-off-by: Jeremi Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GHA CI for PRs from external contributors
GHA CI fails for PRs from external contributors because in devcontainer tests,
emerge-gitclonecan't fetch the right ref from the upstream repository. We can make this work by:git fetch origin <sha>; git checkout FETCH_HEADinemerge-gitcloneThis PRs does "1." and switches to using a branch of flatcar-dev-util that does "2." (https://github.com/flatcar/flatcar-dev-util/compare/jepio/fetch-head - PR will follow if this works).
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.