Skip to content

sysext: turn vim to a sysext image #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

sysext: turn vim to a sysext image #2502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6d34fd
sysext: add vim to a 'tools' sysext image
tormath1 Sep 2, 2025
05e7fb8
use: do not build 'minimal' vim
tormath1 Sep 2, 2025
2e2385f
misc-files: add enabled-sysext.conf
tormath1 Sep 2, 2025
54f88be
changelog: add entry
tormath1 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build_library/extra_sysexts.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ EXTRA_SYSEXTS=(
"nvidia-drivers-570-open|x11-drivers/nvidia-drivers:0/570|kernel-open persistenced|amd64"
"podman|app-containers/podman,net-misc/passt"
"python|dev-lang/python,dev-python/pip"
"tools|app-editors/vim"
"zfs|sys-fs/zfs"
)

Expand Down
1 change: 1 addition & 0 deletions changelog/changes/2025-09-03-sysext-vim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- `vim` is now provided as part of a `tools` sysext image which is enabled by default ([scripts#2502](https://github.com/flatcar/scripts/pull/2502))
0 ...reos-base/coreos/coreos-0.0.1-r318.ebuild → ...reos-base/coreos/coreos-0.0.1-r319.ebuild
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion sdk_container/src/third_party/coreos-overlay/coreos-base/coreos/coreos-0.0.1.ebuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ RDEPEND="${RDEPEND}
app-crypt/gnupg
app-crypt/go-tspi
app-crypt/tpmpolicy
app-editors/vim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To state what was written elsewhere: We might want to still include an emergency editor in the base image. Something like nano is good because it's common, user friendly, and minimal (and many distros have it as default editor).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated comment: I think it would be nice to have mksquashfs and mkfs.erofs available to build sysext images on Flatcar itself, maybe they could also directly go to a tools extension instead of the base image. Not sure if tools or optional extra-tools would be better - in doubt extra-tools to keep the default small?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just worried about the confusion that tools and extra-tools can add. What is extra ? Maybe dev-tools (and this could be part of the sysext devcontainer flatcar/Flatcar#1125)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With "extra" thought we can communicate that these are additional/optional. In the dev extension that would replace the dev container we would have even less common things because most people won't need a compiler and debugger. I think three layers somehow make sense in the long run and should give enough room for package inclusion requests so that we don't add a bunch of other extensions where it's maybe difficult to know how they are compatible with each other once dynamic libraries are involved. For the three layers "tools", "extra(-tools)" and "dev" we should build/generate them stacked so that extra and dev can depend on the contents of "tools" (and "extra") to avoid file conflicts.
This dependency can be documented and we can also add "tools"/"extra" implicitly when parsing the extension config file.

app-editors/nano
app-emulation/qemu-guest-agent
app-containers/cri-tools
app-misc/ca-certificates
Expand Down
1 change: 1 addition & 0 deletions ...r/src/third_party/coreos-overlay/coreos-base/misc-files/files/flatcar/enabled-sysext.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
tools
3 changes: 3 additions & 0 deletions ...os-base/misc-files/misc-files-0-r8.ebuild → ...os-base/misc-files/misc-files-0-r9.ebuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,7 @@ src_install() {
# (The below keepdir will result in a tmpfiles entry in base_image_var.conf)
keepdir /var/kubernetes/kubelet-plugins/volume/exec
dosym /var/kubernetes/kubelet-plugins/volume/exec /usr/libexec/kubernetes/kubelet-plugins/volume/exec

insinto "/usr/share/flatcar"
doins "${FILESDIR}/flatcar/enabled-sysext.conf"
}
0 ...-packages/board-packages-0.0.1-r17.ebuild → ...-packages/board-packages-0.0.1-r18.ebuild
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions ...er/src/third_party/coreos-overlay/coreos-devel/board-packages/board-packages-0.0.1.ebuild
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ RDEPEND="
app-containers/docker-buildx
app-containers/docker-cli
app-containers/incus
app-editors/vim
app-emulation/amazon-ssm-agent
app-emulation/hv-daemons
app-emulation/wa-linux-agent
Expand Down
4 changes: 2 additions & 2 deletions sdk_container/src/third_party/coreos-overlay/profiles/coreos/targets/generic/package.use
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# Distributed under the terms of the GNU General Public License v2

app-admin/sudo ldap sssd
# -crypt: Disable crypt to avoid installing libsodlium.
app-editors/vim minimal -crypt
# -crypt: Disable crypt to avoid installing libsodium.
app-editors/vim -crypt
# minimal: Don't pull app-vim/gentoo-syntax
app-editors/vim-core minimal

Expand Down
Loading