prod_image_util.sh: Temporarily nobble removing unsigned kernel and GRUB#2528
Merged
prod_image_util.sh: Temporarily nobble removing unsigned kernel and GRUB#2528
Conversation
We would normally remove these for an official build so that the signed versions can be uploaded later. However, we are not doing that signing until we pass the shim review. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
tormath1
approved these changes
Dec 13, 2024
Contributor
tormath1
left a comment
tormath1
left a comment
There was a problem hiding this comment.
Thanks, can you also backport this to the new Alpha branch please: flatcar-4186 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily nobble removing unsigned kernel and GRUB
We would normally remove these for an official build so that the signed versions can be uploaded later. However, we are not doing that signing until we pass the shim review.
How to use
Do a release!
Testing done
I ran shellcheck. We'll do a release to see whether this works now.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc. -- N/A