Conversation
Exceptions for Lutris, relating to the following pull requests: flathub/net.lutris.Lutris#488 flathub/net.lutris.Lutris#531 https://github.com/Open-Wine-Components/umu-launcher/wiki/Frequently-asked-questions-(FAQ)#how-do-i-use-a-proton-that-is-installed-in-a-system-path
github-actions
bot
added
the
exceptions
| "finish-args-unnecessary-xdg-data-umu-create-access": "Uses shared installation for the umu runtime", | ||
| "finish-args-unnecessary-xdg-data-Steam-create-access": "Uses shared installation for Proton builds", | ||
| "finish-args-unnecessary-xdg-config-MangoHud-ro-access": "Access shared MangoHud configuration files", | ||
| "finish-args-unnecessary-xdg-cache-lutris-create-access": "Access to Lutris cache directory", |
There was a problem hiding this comment.
Why you need to mount host cache directory instead of using flatpak default one?
There was a problem hiding this comment.
Lutris, non-Flatpak'ed and Flatpak'ed alike, are set to use this directory: https://github.com/lutris/lutris/blob/a5b1a4eda7361292de0239b0cf5bbc20562b7979/lutris/settings.py#L31
I actually should also add xdg-config/lutris and xdg-data/lutris (similarly defined on lines 21 and 22)...
There was a problem hiding this comment.
Unlike non-flatpak, flatpak sets XDG_*_HOME env variables though so the cache, config and data paths are different between flatpak & non-flatpak installations. lutris flatpak shouldn't use host ones right now, even with --filesystem=home. Your change would mount host paths on flatpak specific path (effectively sharing flatpak & non-flatpak installations) which would be brand new behavior and possibly unwanted.
There was a problem hiding this comment.
I can't precisely account for the actual functioning of code that handles xdg-cache/lutris, xdg-config/lutris, or xdg-data/lutris -- but my naive understanding is that, under some parameters, Lutris intentionally bypasses Flatpak paths, in favour of host paths?
At least, in plain English, this is explicitly explained as the intent of some subdirectories that point to xdg-data/lutris: lutris/lutris#6503
There was a problem hiding this comment.
No there is no reason to bypass Flatpak's cache folder location here.
There was a problem hiding this comment.
but my naive understanding is that, under some parameters, Lutris intentionally bypasses Flatpak paths, in favour of host paths?
At least, in plain English, this is explicitly explained as the intent of some subdirectories that point to xdg-data/lutris: lutris/lutris#6503
The paths mentioned in that thread aren't from lutris but from 3rd party tools like steam or umu launcher. Lutris don't control what paths those use but does control its own paths.
|
you aren't a maintainer of the lutris flatpak and no maintainer has commented there. so this is on hold. at this point we don't know if the PRs adding the permissions will be accepted by lutris maintainers. |
3 participants
Exceptions for Lutris, relating to the following pull requests:
https://github.com/Open-Wine-Components/umu-launcher/wiki/Frequently-asked-questions-(FAQ)#how-do-i-use-a-proton-that-is-installed-in-a-system-path