Skip to content

Fix building of sdl12-compat on 25.08 #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbhtt merged 1 commit into from
Sep 3, 2025
Merged

Fix building of sdl12-compat on 25.08 #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions SDL/sdl12-compat-cmake-version.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff -ruN a/CMakeLists.txt b/CMakeLists.txt
--- a/CMakeLists.txt 2023-09-26 19:43:48.000000000 +0200
+++ b/CMakeLists.txt 2025-09-03 17:35:15.362613583 +0200
@@ -2,7 +2,7 @@
# you can define SDL2_INCLUDE_DIR on the cmdline. For example:
# cmake -DSDL2_INCLUDE_DIR=/opt/SDL2/include/SDL2 [other stuff]

-cmake_minimum_required(VERSION 3.0.0...3.5)
+cmake_minimum_required(VERSION 3.0.0...4.0)
project(sdl12_compat
VERSION 1.2.68
LANGUAGES C)
4 changes: 4 additions & 0 deletions SDL/sdl12-compat.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
"type": "archive",
"url": "https://github.com/libsdl-org/sdl12-compat/archive/refs/tags/release-1.2.68.tar.gz",
"sha256": "63c6e4dcc1154299e6f363c872900be7f3dcb3e42b9f8f57e05442ec3d89d02d"
},
{
"type": "patch",
"path": "sdl12-compat-cmake-version.patch"
Copy link
Collaborator

@hfiguiere hfiguiere Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of a patch you could just pass -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to cmake as per the error message.

Copy link
Contributor Author

@JakobDev JakobDev Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but this has been added in CMake 4.0, so I'm not sure if this would cause Problems when building on 24.08.

}
],
"modules": [
Expand Down