Draft
Conversation
Contributor
Author
|
I will add test to this, but not sure when -- I'm on vacation most of this week, so let's do after upcoming release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug pointed out by @rcalfredson and implements fix suggested by @j-friedrich in discussion #1190
Type of change
Has your PR been tested?
caimanmanager testpasses.I ran:
np.allclose(corr_im_local, corr_im_fft, rtol=1e-05, atol=1e-05, equal_nan=True)Where
corr_im_localis the output of the buggy functioncm.local_correlations(), andcorr_im_fftis the output of the more canonical fft-based correlation functioncm.summary_images.local_correlations_fft()until it came back
True.I haven't added this to the test suite. It might be a good idea though.