Skip to content

Add check on length of very long quick exports#347

Merged
WardBrian merged 1 commit intomainfrom
quick-share-limit
Feb 23, 2026
Merged

Add check on length of very long quick exports#347
WardBrian merged 1 commit intomainfrom
quick-share-limit

Conversation

@WardBrian
Copy link
Collaborator

Testing after #346 was deployed, it seems like Vercel specifically gives up at 32,800 characters in a URL. This gives us at least one bound we can use to help users, even if it's possible for specific browsers to still be lower.

@WardBrian WardBrian requested a review from jsoules February 23, 2026 18:00
@codecov-commenter
Copy link

Bundle Report

Changes will increase total bundle size by 294 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
stan-playground-esm 6.72MB 294 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: stan-playground-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 292 bytes 380.45kB 0.08%
assets/index-*.css 2 bytes 2.74kB 0.07%

Files in assets/index-*.js:

  • ./src/localStyles.css → Total Size: 0 bytes

  • ./src/app/windows/ExportProjectWindow/GistExportPanel.tsx → Total Size: 3.68kB

  • ./src/app/windows/ExportProjectWindow/InvitationToShareArea.tsx → Total Size: 632 bytes

  • ./src/app/windows/ExportProjectWindow/GistUpdatePanel.tsx → Total Size: 3.66kB

  • ./src/app/windows/ExportProjectWindow/QuickSharePanel.tsx → Total Size: 1.48kB

  • ./src/app/windows/ExportProjectWindow/ExportProjectPanel.tsx → Total Size: 5.86kB

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.01%. Comparing base (a53ee74) to head (a683f64).

Files with missing lines Patch % Lines
...pp/windows/ExportProjectWindow/QuickSharePanel.tsx 0.00% 16 Missing ⚠️
...windows/ExportProjectWindow/ExportProjectPanel.tsx 0.00% 1 Missing ⚠️
...pp/windows/ExportProjectWindow/GistExportPanel.tsx 0.00% 1 Missing ⚠️
...pp/windows/ExportProjectWindow/GistUpdatePanel.tsx 0.00% 1 Missing ⚠️
...dows/ExportProjectWindow/InvitationToShareArea.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   17.04%   17.01%   -0.04%     
==========================================
  Files         106      106              
  Lines        7004     7017      +13     
  Branches      210      210              
==========================================
  Hits         1194     1194              
- Misses       5808     5821      +13     
  Partials        2        2              
Files with missing lines Coverage Δ
...windows/ExportProjectWindow/ExportProjectPanel.tsx 0.00% <0.00%> (ø)
...pp/windows/ExportProjectWindow/GistExportPanel.tsx 0.00% <0.00%> (ø)
...pp/windows/ExportProjectWindow/GistUpdatePanel.tsx 0.00% <0.00%> (ø)
...dows/ExportProjectWindow/InvitationToShareArea.tsx 5.55% <0.00%> (ø)
...pp/windows/ExportProjectWindow/QuickSharePanel.tsx 3.33% <0.00%> (-2.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for catching things on the export end.

I think for the other end--somebody has a URI that's too long for the browser--we're just cooked; the nature of the problem is that the server will error out before we have a chance to handle it gracefully (as otherwise we could've just handled it correctly). Oh well.

@WardBrian
Copy link
Collaborator Author

Yeah, if only there was some way to have a client-only url parameter that doesn't get sent anywhere.

@WardBrian WardBrian merged commit 3fc83ea into main Feb 23, 2026
2 checks passed
@WardBrian WardBrian deleted the quick-share-limit branch February 23, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants