Add check on length of very long quick exports#347
Conversation
Bundle ReportChanges will increase total bundle size by 294 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: stan-playground-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 17.04% 17.01% -0.04%
==========================================
Files 106 106
Lines 7004 7017 +13
Branches 210 210
==========================================
Hits 1194 1194
- Misses 5808 5821 +13
Partials 2 2
🚀 New features to boost your workflow:
|
jsoules
left a comment
There was a problem hiding this comment.
This looks good for catching things on the export end.
I think for the other end--somebody has a URI that's too long for the browser--we're just cooked; the nature of the problem is that the server will error out before we have a chance to handle it gracefully (as otherwise we could've just handled it correctly). Oh well.
|
Yeah, if only there was some way to have a client-only url parameter that doesn't get sent anywhere. |
Testing after #346 was deployed, it seems like Vercel specifically gives up at 32,800 characters in a URL. This gives us at least one bound we can use to help users, even if it's possible for specific browsers to still be lower.