-
Notifications
You must be signed in to change notification settings - Fork 121
poetry: support for poetry metadata format 2.0 #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for this! I applied this as a patch and it has solved the problem for me when running |
ENDrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe could also add a line in README.md listing metadata formats supported, but not sure if that's necessary. @mig5, since this worked for you could you also please add an approving review?
|
I really think we should merge this |
|
Would also be nice if the https://github.com/flatpak/flatpak-builder-tools/blob/master/pip/flatpak-pip-generator#L55-L67 |
|
Can you rebase this? We could get it merged eventually. |
|
|
|
@GabMus unless this gets rebased, this can't be merged. |
|
rebased, note that this PR is ancient and I don't even use flatpak-builder-tools anymore, so make sure this works as expected before merging |
|
I'll try to review and merge this in the next weeks. It would have been nice if the lock file format was documented but according to https://github.com/orgs/python-poetry/discussions/6763 it's not. In the meantime, |
This should be a separate issue. You just include the generated manifest. Having multiple formats is not a top priority.
Indeed, generic group support can be done later. This can be a separate issue. For now |
accomodate for missing category in package Fixes flatpak#371
This should later be expanded to support any group akin to poetry's --with and --without GROUP args
|
Tested this on a v1 and v2 lock files with the |
No description provided.