Skip to content

flatpak-cargo-builder: unwrap tomldoc#482

Merged
bbhtt merged 1 commit intoflatpak:masterfrom
theoden8:theoden8/fix-cargo
Aug 16, 2025
Merged

flatpak-cargo-builder: unwrap tomldoc#482
bbhtt merged 1 commit intoflatpak:masterfrom
theoden8:theoden8/fix-cargo

Conversation

@theoden8
Copy link
Contributor

this was generating invalid hashes because tomlkit.load and tomlkit.parse return TomlDocument instead of dict.

@theoden8 theoden8 requested a review from a team as a code owner August 16, 2025 15:43
@github-actions github-actions bot added the cargo Rust cargo label Aug 16, 2025
@bbhtt
Copy link
Collaborator

bbhtt commented Aug 16, 2025

Where was it producing wrong hashes?

@bbhtt
Copy link
Collaborator

bbhtt commented Aug 16, 2025

also prefix the commit message with cargo:

@theoden8
Copy link
Contributor Author

...
- type: archive
  archive-type: tar-gzip
  url: https://static.crates.io/crates/zstd-sys/zstd-sys-2.0.15+zstd.1.5.7.crate
  sha256: !!python/object/apply:tomlkit.items.String
  - *id001
  - eb81183ddd97d0c74cedf1d50d85c8d08c1b8b68ee863bdee9e706eedba1a237
  - eb81183ddd97d0c74cedf1d50d85c8d08c1b8b68ee863bdee9e706eedba1a237
  - !!python/object:tomlkit.items.Trivia
    indent: ''
    comment_ws: ''
    comment: ''
    trail: '

      '
  dest: cargo/vendor/zstd-sys-2.0.15+zstd.1.5.7
...

it wasn't serializing right

@bbhtt
Copy link
Collaborator

bbhtt commented Aug 16, 2025

Ah right, I forgot about the YAML output.

@bbhtt bbhtt merged commit f03a673 into flatpak:master Aug 16, 2025
1 check passed
@theoden8 theoden8 deleted the theoden8/fix-cargo branch August 16, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cargo Rust cargo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants