docs: Mention nested modules don't inherit build-options#636
Merged
TingPing merged 1 commit intoflatpak:mainfrom Mar 20, 2025
Merged
docs: Mention nested modules don't inherit build-options#636TingPing merged 1 commit intoflatpak:mainfrom
build-options#636TingPing merged 1 commit intoflatpak:mainfrom
Conversation
Member
|
Its harmless for this specific option so I don't mind, but its more of a general concept that module scopes are isolated. Only the global one is inherited. |
Contributor
Author
See #637 for a follow-up addition. Another question: Would it be possible somehow to display a table of contents for the "Command Reference" pages, i.e. have a floating "On this page" ToC on the right side of the rendered page? Without it, it's really hard to keep an overview... |
bbhtt
pushed a commit
that referenced
this pull request
Sep 2, 2025
* docs: Be explicit about module scope isolation Follow-up to #636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it makes sense to explicitly mention this since it's kinda counterintuitive to what one might expect.