Record licensing information of modules #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
swick
commented
Sep 1, 2025
swick
commented
bbhtt
reviewed
Sep 1, 2025
Contributor
|
Would be nice to have the doc bits as well. |
bbhtt
reviewed
Sep 1, 2025
swick
force-pushed
the
wip/license-files
branch
from
4c446d2 to
d9e6fbb
Compare
Contributor
Author
|
Addressed the feedback. |
Contributor
Author
|
The CI failure looks like an infra issue but I can't re-run the jobs. |
Contributor
|
Retriggered them, I can test it a bit tomorrow. Seems ok. |
Contributor
|
I think @AdrianVovk was interested too, in case you want to have a look. |
bbhtt
added a commit
to flathub/org.flatpak.Builder
that referenced
this pull request
Sep 2, 2025
bbhtt
reviewed
Sep 2, 2025
Contributor
|
Seems to work otherwise from my tests. |
We want to be able to record the licensing information about the modules that we build in /app/share/licenses/$MODULE_NAME. The changes here do two things: 1. Every module that gets build is searched for a bunch of common names for licensing files and every match is copied to the target dir. 2. The new `license-files` key can be used to specify the license files of a module which must be found for the stage to succeed.
This tests the automatic detection of licensing files and also the explicit `license-files` key.
swick
force-pushed
the
wip/license-files
branch
from
d9e6fbb to
2cf6452
Compare
Contributor
|
Looks good from my side, thanks. |
Contributor
|
Looks good to me as well, nothing jumps out |
Contributor
|
If there aren't any comments, we should merge this. Then I can deploy it to Flathub where it will get some widespread testing. Once that is done, we can probably tag a new release (with accumulated fixes from that if any). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.