builder-git: Checkout LFS objects #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbhtt
force-pushed
the
bbhtt/lfs
branch
2 times, most recently
from
cc5039c to
6ea6298
Compare
swick
reviewed
Sep 3, 2025
swick
reviewed
Sep 4, 2025
Contributor
Author
|
I ended up refactoring the entire thing a bit, hopefully it makes sense. Need to test if this version is working later. |
swick
reviewed
Sep 4, 2025
swick
reviewed
Sep 4, 2025
hfiguiere
reviewed
Sep 8, 2025
hfiguiere
reviewed
Sep 8, 2025
swick
approved these changes
Sep 15, 2025
bbhtt
commented
Sep 16, 2025
bbhtt
force-pushed
the
bbhtt/lfs
branch
2 times, most recently
from
a415cbf to
fdb3e30
Compare
This explicitly fetches Git LFS objects as long as git-lfs is available on host (but doesn't need to be configured) Fixes #463 Co-authored-by: Bartłomiej Piotrowski <[email protected]>
The previous commit will attempt to fetch LFS by default for Git sources even if LFS is not configured (but available). This allows to disable that behaviour on a per source basis since repos may have huge LFS assets which may be undesirable to fetch.
Contributor
Author
|
Deployed this to Flathub to test on flathub/dev.mariinkys.Oboete#15 Seems to work. Combined with this change, flathub/org.flatpak.Builder@1b28ed6 |
Contributor
Author
|
I will merge this by the end of the week if nothing else comes up from above testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased, reworded version of #498 with some extra commits.
Closes #498