builder-manifest: Log sdk, runtime and base versions and commits used#667
Merged
builder-manifest: Log sdk, runtime and base versions and commits used#667
Conversation
swick
reviewed
Sep 12, 2025
Comment on lines
+1711
to
+1712
| if (self->sdk_commit != NULL) | ||
| g_debug ("Using %s version %s commit %s", |
Contributor
There was a problem hiding this comment.
The gnome handbook says that one should use parenthesis if there are multiple lines. I know that this is not followed consistently in flatpak-related project, but I wonder if we should enforce this.
Contributor
Author
There was a problem hiding this comment.
i don't have a strong opinion on this, but it is even inconsistent in this file. the instances i could spot except a few are not using braces.
Contributor
|
LGTM in principle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341