builder-module: Add wrap-mode=nodownload to meson if building w/o network#684
Merged
builder-module: Add wrap-mode=nodownload to meson if building w/o network#684
Conversation
bbhtt
force-pushed
the
bbhtt/meson-wrap-nodownload
branch
from
96548ed to
cd2c8d0
Compare
bbhtt
force-pushed
the
bbhtt/meson-wrap-nodownload
branch
from
cd2c8d0 to
6f15120
Compare
swick
approved these changes
Oct 19, 2025
alatiera
reviewed
Oct 20, 2025
| /* Meson's setup command is now meson setup */ | ||
| g_ptr_array_add (configure_args_arr, g_strdup ("setup")); | ||
| if (!build_has_network) | ||
| g_ptr_array_add (configure_args_arr, g_strdup ("--wrap-mode=nodownload")); |
Contributor
There was a problem hiding this comment.
Could you copy over the lengthy comment form #643 as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #643
Closes #643