Closed
Conversation
Add Ang Obs for Bs2Phiee
peterstangl
requested changes
Sep 11, 2024
|
|
||
| import flavio | ||
| from . import observables | ||
| import observables |
Member
There was a problem hiding this comment.
Is there a particular reason why this has been changed? I think here the relative import should be kept.
Member
There was a problem hiding this comment.
If you look at the output of the unit tests, you will see that this change actually leads to ModuleNotFoundError: No module named 'observables'
| 'S3': {'func_num': lambda y, J, J_bar, J_h: S_experiment_num_Bs(y, J, J_bar, J_h, 3), 'tex': r'\overline{S_3}', 'desc': 'Time-averaged, CP-averaged angular observable'}, | ||
| 'S4': {'func_num': lambda y, J, J_bar, J_h: S_experiment_num_Bs(y, J, J_bar, J_h, 4), 'tex': r'\overline{S_4}', 'desc': 'Time-averaged, CP-averaged angular observable'}, | ||
| 'S5': {'func_num': lambda y, J, J_bar, J_h: S_experiment_num_Bs(y, J, J_bar, J_h, 5), 'tex': r'\overline{S_5}', 'desc': 'Time-averaged, CP-averaged angular observable'}, | ||
| 'S5': {'func_num': lambda y, J, J_bar, J_h: S_experiment_num_Bs(y, J, J_bar, J_h, 5), 'tex': r'\overline{S_5}', 'desc': 'Time-averaged, CP-averaged angular observable'}, |
Member
There was a problem hiding this comment.
The two lines above are exactly the same, but S6c is missing.
| _observables_p = { | ||
| 'P1': {'func_num': lambda y, J, J_bar, J_h: S_experiment_num_Bs(y, J, J_bar, J_h, 3)/2., 'tex': r'P_1', 'desc': "CP-averaged \"optimized\" angular observable"}, | ||
| 'ATIm': {'func_num': lambda y, J, J_bar, J_h: A_experiment_num_Bs(y, J, J_bar, J_h, 9)/2., 'tex': r'A_T^\text{Im}', 'desc': "Transverse CP asymmetry"}, | ||
| 'ATRe': {'func_num': lambda y, J, J_bar, J_h: A_experiment_num_Bs(y, J, J_bar, J_h, 9)/4., 'tex': r'A_T^\text{2}', 'desc': "\"optimized\" angular CP asymmetry"}, |
Member
There was a problem hiding this comment.
There are several issues here:
- The function used for the prediction of
ATReis just 1/2 times the one used forATIm, which seems to be wrong. - The tex name of
ATReisA_T^\text{2}, which seems to be a different observable.
| _obs.set_description(obsdict['desc'][0].capitalize() + obsdict['desc'][1:] + r" in $" + _process_tex + r"$") | ||
| _obs.tex = r"$" + obsdict['tex'] + r"(" + _process_tex + r")$" | ||
| _obs.add_taxonomy(_process_taxonomy) | ||
| return _obs |
Member
There was a problem hiding this comment.
These two functions make_metadata_binned_Bs and make_metadata_differential_Bs do not seem to be used anywhere at the moment.
Member
|
This PR has been superseded by PR #274. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ang Obs for Bs2Phiee