fix(perf): fixed massive performance issue in simplification steps for Polyline/gonLayers
#1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
requested review from
TesteurManiak,
ibrierley,
josxha and
mootw
josxha
approved these changes
Nov 24, 2024
|
Sounds exciting, can't wait to test. As you know, I am into "massive performance increases" myself :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caching of the simplification was not working correctly, and creating massive overheads.
Essentially, we were storing a lazily-generated
Iterablein the simplification cache. This means that it was fully re-generated (re-simplified) on every cache retrieval: simplification had to run every frame. We now store a non-growableList.Before:
After:
