Skip to content

fix(perf): fixed massive performance issue in simplification steps for Polyline/gonLayers #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaffaKetchup merged 2 commits into from
Nov 24, 2024
Merged

fix(perf): fixed massive performance issue in simplification steps for Polyline/gonLayers #1991

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a951df1
Fixed large performance issue in simplification
JaffaKetchup Nov 24, 2024
8cb4c3e
Merge branch 'master' into fixed-perf-bug-simplification
JaffaKetchup Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/src/layer/shared/layer_projection_simplification/state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ mixin ProjectionSimplificationManagement<
///
/// Do not use before invoking [build]. Only necessarily up to date directly
/// after [build] has been invoked.
late Iterable<ProjectedElement> simplifiedElements;
late List<ProjectedElement> simplifiedElements;

Iterable<ProjectedElement>? _cachedProjectedElements;
final _cachedSimplifiedElements = <int, Iterable<ProjectedElement>>{};
List<ProjectedElement>? _cachedProjectedElements;
final _cachedSimplifiedElements = <int, List<ProjectedElement>>{};

double? _devicePixelRatio;

Expand Down Expand Up @@ -89,12 +89,12 @@ mixin ProjectionSimplificationManagement<
}

simplifiedElements =
(_cachedSimplifiedElements[camera.zoom.floor()] ??= _simplifyElements(
_cachedSimplifiedElements[camera.zoom.floor()] ??= _simplifyElements(
camera: camera,
projectedElements: projected,
pixelTolerance: widget.simplificationTolerance,
devicePixelRatio: newDPR,
));
).toList(growable: false);
}

return Builder(
Expand Down
Loading