feat: added keyboard controls for map gestures #1987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
requested review from
TesteurManiak,
ibrierley,
josxha and
mootw
Switched to using `Focus` instead of `KeyboardListener` to properly take focus and make bubbling decisions Added optional external `foucsNode` & `autofocus` input to `KeyboardOptions` Documented recommendation to enable arrow keys if WASD enabled (for left handed users)
Fixed returned `KeyEventResult`s
JaffaKetchup
requested review from
a team
and removed request for
TesteurManiak,
ibrierley,
josxha and
mootw
Normalise pan offset per frame to ensure magnitude does not exceed max velocity
Member
Author
|
Here's a testing link: https://fleaflet-firebase--arrow-keys-2-x6i5j8cb.web.app/interactive_flags_page |
…d movement Changed defaults
Fixed bug
Improved documentation on `KeyboardOptions` and properties Changed defaults Minor improvements
josxha
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds keyboard controls for the map, each of which may be toggled individually. By default, only the new arrow key gestures work - but maybe it would be better to enable them all?
Supports arrow & WASD keys for panning, QE keys for rotation, and RF keys for zoom (assuming QWERTY). All keys are physical not logical, so whatever key is in those positions on a QWERTY keyboard will work the same on others).
A potential extension could be to allow a key to be defined which resets the map rotation. And/or, to allow more customizability with keys (eg. to better support rotation and zooming for left handed users using the arrow keys).