fix: calculate LayerHitResult.coordinate correctly
#2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `.coordinate` demo to Polygons example Removed `FeatureLayerUtils.origin` in favour of `MapCamera.pixelOrigin`
Member
Author
|
@monsieurtanuki I believe it was while we were messing about with the feature layer painting that |
Contributor
|
@JaffaKetchup I'll try to have a look at it this week. Sorry about the delay. |
monsieurtanuki
approved these changes
May 29, 2025
Contributor
monsieurtanuki
left a comment
monsieurtanuki
left a comment
There was a problem hiding this comment.
@JaffaKetchup LGTM
josxha
reviewed
Jul 8, 2025
josxha
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2092.
Also added
.coordinatedemo to Polygons example.I also removed
FeatureLayerUtils.originin favour ofMapCamera.pixelOrigin. I'm not 100% if this is correct, but it seems to make sense.