Skip to content

perf: preserve Marker widget state when list of visible markers changes #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

perf: preserve Marker widget state when list of visible markers changes #2131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ed7c86
fix: Added value key and RepaintBoundary to preserve Marker state.
ReinisSprogis Jul 21, 2025
a9f6442
Using ObjectKey if key not provided.
ReinisSprogis Jul 22, 2025
7308fbd
Merge branch 'master' into marker_fix
JaffaKetchup Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions lib/src/layer/marker_layer/marker_layer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,23 +72,22 @@ class MarkerLayer extends StatelessWidget {

// Shift original coordinate along worlds, then move into relative
// to origin space
final shiftedLocalPoint =
Offset(shiftedX, pxPoint.dy) - map.pixelOrigin;

final shiftedLocalPoint = Offset(shiftedX, pxPoint.dy) - map.pixelOrigin;

final markerKey = m.key ?? ObjectKey(m);
return Positioned(
key: m.key,
width: m.width,
height: m.height,
left: shiftedLocalPoint.dx - right,
top: shiftedLocalPoint.dy - bottom,
child: (m.rotate ?? rotate)
? Transform.rotate(
angle: -map.rotationRad,
alignment: (m.alignment ?? alignment) * -1,
child: m.child,
)
: m.child,
);
key: ValueKey('$markerKey@$shiftedX'),
width: m.width,
height: m.height,
left: shiftedLocalPoint.dx - right,
top: shiftedLocalPoint.dy - bottom,
child: RepaintBoundary(child: (m.rotate ?? rotate)
? Transform.rotate(
angle: -map.rotationRad,
alignment: (m.alignment ?? alignment) * -1,
child: m.child,
)
: m.child));
}

// Create marker in main world, unless culled
Expand Down
Loading