-
Notifications
You must be signed in to change notification settings - Fork 0
FOGL-9963 Add Alerts as a source for notifications #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d42fb17
FOGL-9963 Add Alerts as a source for notifications
MarkRiddoch 986a170
Remove unwanted debug log message
MarkRiddoch 92cf16f
Merge branch 'develop' into FOGL-9963
MarkRiddoch 2f039fb
Add documentation of the new notification source
MarkRiddoch 3ffa5a6
Merge branch 'FOGL-9963' of https://github.com/fledge-iot/fledge-serv…
MarkRiddoch 56dadba
Add comprehensive unit tests for DataAvailabilityRule
MarkRiddoch 75f0ace
Add comprehensive unit tests for notification_subscription.cpp
MarkRiddoch f1b6e05
Add comprehensive unit tests for notification_queue.cpp
MarkRiddoch f984d05
Removed failed cursor unit tests
MarkRiddoch 70306ac
Updated unit tests
MarkRiddoch a1b5e15
Merge branch 'develop' into FOGL-9963
MarkRiddoch 833f636
Update next round of review comments
MarkRiddoch 7889c20
FOGL-9963 Add macro substitution into the message string and add the
MarkRiddoch c2b192d
Add alert example
MarkRiddoch e95d88c
Add expandMacros unit test
MarkRiddoch ac4e8a9
Add documentation for macro substitution
MarkRiddoch 0a495ba
Macro update
MarkRiddoch 682ff5a
Fix typos
MarkRiddoch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the hardcoded string value "alert", same as key?
In future, We better use
doc.AddMember
to avoid fragile and cumbersome string building!