Skip to content

Conversation

@arobsn
Copy link
Member

@arobsn arobsn commented May 6, 2025

Closes #173
Closes #174

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: d6fa564

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@fleet-sdk/serializer Patch
@fleet-sdk/common Patch
@fleet-sdk/compiler Patch
@fleet-sdk/core Patch
@fleet-sdk/mock-chain Patch
@fleet-sdk/wallet Patch
@fleet-sdk/ageusd-plugin Patch
@fleet-sdk/babel-fees-plugin Patch
@fleet-sdk/blockchain-providers Patch
@fleet-sdk/crypto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 6, 2025

@fleet-sdk/blockchain-providers

npm i https://pkg.pr.new/@fleet-sdk/blockchain-providers@175

@fleet-sdk/common

npm i https://pkg.pr.new/@fleet-sdk/common@175

@fleet-sdk/compiler

npm i https://pkg.pr.new/@fleet-sdk/compiler@175

@fleet-sdk/core

npm i https://pkg.pr.new/@fleet-sdk/core@175

@fleet-sdk/crypto

npm i https://pkg.pr.new/@fleet-sdk/crypto@175

@fleet-sdk/mock-chain

npm i https://pkg.pr.new/@fleet-sdk/mock-chain@175

@fleet-sdk/serializer

npm i https://pkg.pr.new/@fleet-sdk/serializer@175

@fleet-sdk/wallet

npm i https://pkg.pr.new/@fleet-sdk/wallet@175

@fleet-sdk/ageusd-plugin

npm i https://pkg.pr.new/@fleet-sdk/ageusd-plugin@175

@fleet-sdk/babel-fees-plugin

npm i https://pkg.pr.new/@fleet-sdk/babel-fees-plugin@175

commit: d6fa564

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d7eee65) to head (d6fa564).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #175    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          125       125            
  Lines        13736     14357   +621     
  Branches      1665      1702    +37     
==========================================
+ Hits         13736     14357   +621     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arobsn arobsn requested a review from Copilot May 11, 2025 00:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the internal usage of fee-related constants while adding Box and Transaction deserialization support. Key changes include dependency updates in the crypto package, import refactoring in core modules to source constants from the common package, and an enhancement to the startsWith utility function to support an offset parameter.

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/crypto/package.json Updated dependency versions for cryptography libraries
packages/core/src/models/ergoUnsignedTransaction.spec.ts Refactored imports to use constants from @fleet-sdk/common
packages/core/src/models/ergoAddress.ts & .spec.ts Adjusted imports for fee constants and output consistency
packages/core/src/builder/transactionBuilder.ts Removed internal fee constant declarations in favor of common
packages/common/src/utils/array.ts & array.spec.ts Extended startsWith to include an optional offset parameter
packages/common/src/constants.ts Added centralized fee constant definitions
Root package.json & workflows (.github) Updated dependency versions, permissions, and pnpm configuration
.changeset files Documented changes for new deserialization functions
Comments suppressed due to low confidence (2)

packages/common/src/utils/array.ts:208

  • [nitpick] Please update the function's documentation to describe the new 'offset' parameter and its intended behavior.
export function startsWith<T>(array: ArrayLike<T>, target: ArrayLike<T>, offset = 0): boolean {

packages/core/src/builder/transactionBuilder.ts:50

  • Since fee constants are now exported from '@fleet-sdk/common', ensure that any internal references to FEE_CONTRACT and RECOMMENDED_MIN_FEE_VALUE are updated accordingly to maintain consistency.
export const RECOMMENDED_MIN_FEE_VALUE = BigInt(1100000);

@arobsn arobsn merged commit 13df73a into master May 11, 2025
16 checks passed
@arobsn arobsn deleted the add-tx-parsing branch May 11, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add transaction deserialization Add box deserialization

2 participants