-
Notifications
You must be signed in to change notification settings - Fork 12
Add Box and Transaction deserialization #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d6fa564 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@fleet-sdk/blockchain-providers
@fleet-sdk/common
@fleet-sdk/compiler
@fleet-sdk/core
@fleet-sdk/crypto
@fleet-sdk/mock-chain
@fleet-sdk/serializer
@fleet-sdk/wallet
@fleet-sdk/ageusd-plugin
@fleet-sdk/babel-fees-plugin
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 125 125
Lines 13736 14357 +621
Branches 1665 1702 +37
==========================================
+ Hits 13736 14357 +621 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the internal usage of fee-related constants while adding Box and Transaction deserialization support. Key changes include dependency updates in the crypto package, import refactoring in core modules to source constants from the common package, and an enhancement to the startsWith utility function to support an offset parameter.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/crypto/package.json | Updated dependency versions for cryptography libraries |
| packages/core/src/models/ergoUnsignedTransaction.spec.ts | Refactored imports to use constants from @fleet-sdk/common |
| packages/core/src/models/ergoAddress.ts & .spec.ts | Adjusted imports for fee constants and output consistency |
| packages/core/src/builder/transactionBuilder.ts | Removed internal fee constant declarations in favor of common |
| packages/common/src/utils/array.ts & array.spec.ts | Extended startsWith to include an optional offset parameter |
| packages/common/src/constants.ts | Added centralized fee constant definitions |
| Root package.json & workflows (.github) | Updated dependency versions, permissions, and pnpm configuration |
| .changeset files | Documented changes for new deserialization functions |
Comments suppressed due to low confidence (2)
packages/common/src/utils/array.ts:208
- [nitpick] Please update the function's documentation to describe the new 'offset' parameter and its intended behavior.
export function startsWith<T>(array: ArrayLike<T>, target: ArrayLike<T>, offset = 0): boolean {
packages/core/src/builder/transactionBuilder.ts:50
- Since fee constants are now exported from '@fleet-sdk/common', ensure that any internal references to FEE_CONTRACT and RECOMMENDED_MIN_FEE_VALUE are updated accordingly to maintain consistency.
export const RECOMMENDED_MIN_FEE_VALUE = BigInt(1100000);
Closes #173
Closes #174